Open viceice opened 1 year ago
Maybe we can do it in without breaking
Any changes to depType
needed to differentiate them afterward?
gitlabci-includes
only uses repository
https://github.com/renovatebot/renovate/blob/ba3b0c2323ef6c2d263632f28f7895398fefb844/lib/modules/manager/gitlabci-include/extract.ts#L20-L34
gitlabci
also traverses local includes, so we do that twice for docker images in gitlabci
and for repository includes at gitlabci-includes
🙈
ProgammingLanguage=docker will be applied then 😕 https://github.com/renovatebot/renovate/blob/ba3b0c2323ef6c2d263632f28f7895398fefb844/lib/modules/manager/gitlabci/index.ts#L5
@viceice -> gitlabci-includes handles the following types:
include:
- project: my-proj/pipelines/node-pipeline
file: pipeline/node-pipeline.yml
ref: 2.5.0
whereas gitlabci handles docker tags etc referenced in a gitlab-ci.yml e.g.
image: renovate/renovate:37-slim@sha256:4bfa4c3ec7c3ddf695283a6b22c3019ac77503597e5ad836ab3b34288a8cc961
I've seen you comment on: https://github.com/renovatebot/renovate/issues/14177 about issues when pinning digests in gitlabci-includes manager.
Would this change ensure that includes don't try and pin, as there is no SHA to pin, but that image references could still be pinned automatically?
yes
What would you like Renovate to be able to do?
The
gitlabci-include
manager should be merged intogitlabci
manager. Both work on same files beside theinclude
manager also follows Gitlab inclcudes and processes them if they are local.If you have any ideas on how this should be implemented, please tell us here.
gitlabci-include
config togitlabci
configIs this a feature you are interested in implementing yourself?
Maybe