renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
17.66k stars 2.33k forks source link

feat(manager/cargo): support for git dependencies #26531

Open secustor opened 10 months ago

secustor commented 10 months ago

Discussed in https://github.com/renovatebot/renovate/discussions/26521

Originally posted by **richvdh** January 5, 2024 ### Tell us more. https://github.com/richvdh/renovate-cargo-git-test is an example of a Cargo project with a git dependency. [`Cargo.lock`](https://github.com/richvdh/renovate-cargo-git-test/blob/main/Cargo.lock#L8) is out of date, and can be updated with `cargo update -p empty-git-lib`. Renovate reports: ```json { "baseBranch": "main" "config": { "cargo": [ { "deps": [ { "currentValue": "0.1.0", "datasource": "crate", "depName": "empty-git-lib", "depType": "dependencies", "lockedVersion": "0.1.0", "managerData": { "nestedVersion": true }, "packageName": "empty-git-lib", "skipReason": "git-dependency", "updates": [] } ], "lockFiles": [ "Cargo.lock" ], "packageFile": "Cargo.toml" } ] } } ``` My understanding, looking at the [source](https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/cargo/extract.ts#L49-L92), is that Renovate will refuse to touch any dependency that comes from a git repo. It would be great if support could be added!

Reproduction: https://github.com/renovate-reproductions/26531

philbucher commented 1 month ago

Hi, This would also be very useful for me.

I noticed that git-dependencies are supported for poetry, perhaps the same concepts could be used here?

mkniewallner commented 1 month ago

Hi, This would also be very useful for me.

I noticed that git-dependencies are supported for poetry, perhaps the same concepts could be used here?

Planning to add support for it, being also interested by that feature (so feel free to assign the issue to me), but ideally not until https://github.com/renovatebot/renovate/pull/31260 is merged.

AzHicham commented 2 weeks ago

Hello Any update for this feature ? Really appreciate your work !!