Open rarkins opened 9 months ago
for me it's more a feature and a versioning misuse 😉
Yeah, it's borderline
While the version constraints mentioned above indeed only claim SemVer compatibilty, Poetry's library versioning guideline dictates pep440
, which actually supports versions like 1.2.3.4.5.6
. Using caret notation for such a version and then running poetry lock
correctly updates dependencies, so poetry itself is compatible.
Also, trying to override this behaviour via versioning didn't work in my case:
// ...
{
"matchDatasources": ["pypi"],
"matchPackageNames": ["acryl-datahub"],
"versioning": "pep440"
}
I do agree that these versions are rather rare, but to me it still feels like a bug in renovate rather than a versioning misuse.
Yes, it's valid poetry syntax so should be supported by "poetry" versioning in Renovate
Discussed in https://github.com/renovatebot/renovate/discussions/26939
Logs
``` DEBUG: packageFiles with updates { "baseBranch": "main" "config": { "poetry": [ { "deps": [ { "datasource": "pypi", "currentValue": "^ 69.0.0.20240115", "managerData": { "nestedVersion": false }, "skipReason": "invalid-version", "depName": "types-setuptools", "depType": "dependencies", "lockedVersion": "69.0.0.20240115", "updates": [], "packageName": "types-setuptools" }, { "datasource": "pypi", "currentValue": ">= 2023.3.1.0", "managerData": { "nestedVersion": false }, "versioning": "pep440", "depName": "types-pytz", "depType": "dependencies", "lockedVersion": "2023.3.1.0", "updates": [ { "bucket": "non-major", "newVersion": "2023.3.1.1", "newValue": ">= 2023.3.1.0", "releaseTimestamp": "2023-09-20T15:14:27.000Z", "newMajor": 2023, "newMinor": 3, "updateType": "patch", "isRange": true, "isLockfileUpdate": true, "branchName": "renovate/types-pytz-2023.x-lockfile" } ], "packageName": "types-pytz", "warnings": [], "sourceUrl": "https://github.com/python/typeshed", "registryUrl": "https://pypi.org/pypi", "changelogUrl": "https://github.com/typeshed-internal/stub_uploader/blob/main/data/changelogs/pytz.md", "currentVersion": "2023.3.1.0", "isSingleVersion": true, "fixedVersion": "2023.3.1.0" } ], "packageFileVersion": "0.1.0", "extractedConstraints": { "python": "^3.11" }, "lockFiles": [ "poetry.lock" ], "packageFile": "pyproject.toml" } ] } } ```