Open RahulGautamSingh opened 1 month ago
Should azureWorkItemId
, bbUseDefaultReviewers
, gitLabIngoreApprovals
be included in this list too? These 3 are a repo config options, whereas all the others options that I included in the pr description are global only options.
Should
azureWorkItemId
be included in this list too? It is a repo config option currently whereas all the others are already global only options.
I'm not sure about that 🤔
Should
azureWorkItemId
,bbUseDefaultReviewers
,gitLabIngoreApprovals
be included in this list too? These 3 are a repo config options, whereas all the others options that I included in the pr description are global only options.
@secustor @rarkins
I'm in favor of including these options there too, as else it is confusing why similar options have to be set at different places.
Then platformOptions
will need to be a repo config option. But we cannot include the global config fields (ie. githubTokenWarn
) when we add platformOptions
to the repo config.
What should we do in this case? I think maybe we can make this option context-aware:
If found in the repo config:
azureWorkitemId
)githubTokenWarn
) if presentIf found in repo config:
we can mark the specific child options as global only, so only they fail validation on repo config. platformOptions
should be mergable.
There is an internal variable with the same name platformOptions which we use for passing options to the createPr
/updatePr
functions. I will need to rename it to say, platformPrOptions
before hand so it doesn't create confusion.
Rhys suggested this option needs a new name. So, I'm adding this to get some recommendations. MAybe platformSettings
?
I don't think githubTokenWarn
should be included in this. Even, though it has a platform in its name, it is used to supress github token warning which can be used by users of any platform while self-hosting.
Can't it be replaced with a log level remap now anyway?
Yes
Describe the proposed change(s).
To improve the organization and accessibility of platform-specific configuration options, combine them under a single config option named
platformOptions
.Example:
_Originally posted by @viceice in https://github.com/renovatebot/renovate/pull/29137#discussion_r1617788554_