search

renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
17.6k stars 2.32k forks source link

Gradle: handle null values produced with 'dependency' keyword #6476

Closed zharinov closed 4 years ago

zharinov commented 4 years ago

What Renovate type are you using?

Standalone

Describe the bug

Gradle report generator handles deps declared with classpath keyword, while sections with dependency produce version: null.

While running, DefaultExternalModuleDependency instances are initiated with null version fields.

To Reproduce

Clone example repo (see below) and run Renovate.

Additional context

Example repo: https://github.com/apache/fineract Example: https://github.com/apache/fineract/blob/develop/fineract-provider/build.gradle#L83

viceice commented 4 years ago

I think this will be fixed with #3608, which is in progress

rarkins commented 4 years ago

I think #3608 might take some time though! I was hoping there's a quick fix here with the existing manager.

zharinov commented 4 years ago

For quick fix, we can scan package file, collecting versions for null values. Should be pretty straightforward to implement.

viceice commented 4 years ago

@zharinov Feel free to send a pr to fix this 🙃

renovate-release commented 4 years ago

:tada: This issue has been resolved in version 21.6.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: