renovatebot / renovate

Home of the Renovate CLI: Cross-platform Dependency Automation by Mend.io
https://mend.io/renovate
GNU Affero General Public License v3.0
16.87k stars 2.2k forks source link

Remove "util/http/legacy.ts" #9651

Open zharinov opened 3 years ago

zharinov commented 3 years ago

What would you like Renovate to be able to do?

Fix what's broken and test on all platforms.

Did you already have any implementation ideas?

zharinov commented 3 years ago

@viceice Please, tell more about legacy.ts rationale during migration between got versions

viceice commented 3 years ago

Yes, it's mainly for provide legacy got error properties. That file should be fully removed.

But unit tests won't catch those issues, because most catch blocks are skipped from code coverage.

So we should check all code using those properties and test it. After that we can fix code and remove legacy stuff.