search

renovatebot / ruby-semver

MIT License
3 stars 5 forks source link

chore(deps): remove explicit dependency on `tslib` #156

Closed JamieMagee closed 1 year ago

JamieMagee commented 1 year ago

Looks like this was done back in #54 when there was a mix of dependencies on tslib 1.x and 2.x. This is no longer the case anymore, and I don't think this is required.

JamieMagee commented 1 year ago

I just checked and setting importHelpers to true or false doesn't affect the output. I assume that because we're using such a new version of Node, and relatively simple features, there are no downleveling helpers required.

From the docs^1:

For certain downleveling operations, TypeScript uses some helper code for operations like extending class, spreading arrays or objects, and async operations. By default, these helpers are inserted into files which use them. This can result in code duplication if the same helper is used in many different modules.

viceice commented 1 year ago

@JamieMagee you should have made this a fix. chore's don't create a new release. so we need to wait for another change to get it release 🙃