search

renqibing / ActorAttack

56 stars 2 forks source link

Some small bugs when running the example run #1

Closed Ytang520 closed 4 weeks ago

Ytang520 commented 1 month ago

Some bugs when running the example run:

  1. filename: (running on Windows) e.g. preattack.py line: 105; inattack.py line: 157. The filename is not supported on Windows.
  2. missing argument: inattack.py line: 138 'actor'

Honestly, it is easy to fix them, esp. when I only use 'gpt-4o-mini' as the target model. I create this issue mostly for the 50 carefully chosen instances used in your paper. I'd like to compare your methods with others, but find it a little bit hard.

Great work! Wait for your next update!

LLLeoLi commented 1 month ago

Thanks for your issue. Could you explain the second bug in more detail?

Ytang520 commented 1 month ago

In attack.py, when using the o1 model, you specify the change in the content of the detail_query and type_query by using the param actor (where there is no default value) you intend to pass. image However, you don't pass legal value to this parameter in your following codes. (I already alter the code in my way as the following, though, it is only suitable for models other than the o1 model) image

renqibing commented 1 month ago

Thank you for your feedback! @LLLeoLi has already fixed the bug. Thanks again for your interest in our work!