search

rensbreur / SwiftTUI

SwiftUI for terminal applications
MIT License
1.23k stars 47 forks source link

ScrollView has hardcoded blue background #7

Closed hassila closed 1 year ago

hassila commented 1 year ago

Just found out that ScrollView seems to work - very, very cool - just found a small thing, in lines 33/35 it overrides the colour to blue:

https://github.com/rensbreur/SwiftTUI/blob/f3756bbf76c64e30afee609827b1f43b12f82e0d/Sources/SwiftTUI/View/Views/Controls/ScrollView.swift#L33

and

https://github.com/rensbreur/SwiftTUI/blob/f3756bbf76c64e30afee609827b1f43b12f82e0d/Sources/SwiftTUI/View/Views/Controls/ScrollView.swift#L35

Seems a bit unexpected?

I just switched from VStack to ScrollView and everything in that view turns blue background :-)

hassila commented 1 year ago

If you'd like I can do a PR with a fix?

hassila commented 1 year ago

I did a PR for it + starting to fix scroll view controls. See link in this issue.