rentalutions / elements

Design kit for Avail rental management software
https://design.avail.co
10 stars 3 forks source link

misalignment when a Tag does not use an icon #79

Open jgrubard opened 4 years ago

jgrubard commented 4 years ago

Prerequisites

Step to reproduce (actual behavior)

@pkrawc I noticed when using the Tag component that when an icon is not passed as a prop there is a slight vertical misalignment between tags.

Screen Shot 2020-04-16 at 5 10 58 PM

Expected behavior

Tags should be aligned whether or not there is an icon prop being used.

Any message or error

N/A

Resources

N/A

jgrubard commented 4 years ago

@pkrawc update: thanks to @tpstar I found that wrapping the tags in a div styled with display: flex allows them to all be vertically aligned with each other.

pkrawc commented 4 years ago

Yeah. That's a bug probably on line-height. Nice workaround for now but will fix soon. Leaving this open to not forget about it. 👍