search

rentpath / identity.js

Track a Universal RentPath Identity
2 stars 0 forks source link

deploy.js should preclude overwrites. #16

Closed martinstreicher closed 8 years ago

martinstreicher commented 8 years ago

The bucket policy doesn't and can't prevent overwrites. (That said, the bucket does include versioning, so if the object is overwritten, that version can be removed (manually by Infra, as the bucket policy doesn't allow for the credentials we have to remove items) and the original version will be available.) Because removing a version requires extra ceremony and headache, it's important that the publishing of versions be programmatic and include a check to make sure we're not publishing something that already exists (we can enforce the overwriting constraints on our end).

martinstreicher commented 8 years ago

The code to skip overwrites was added with commit b90d79fd88f58382fb57e15cbf6351d938c59402