search

rentpath / identity.js

Track a Universal RentPath Identity
2 stars 0 forks source link

[AB][116162145] Load warehouse image pixel outside of DOM #25

Closed aribouius closed 8 years ago

aribouius commented 8 years ago

The code was attempting to append the warehouse image pixel into the DOM before the DOM was ready for inspection (e.g. DOMContentLoaded event). This change removes the need to wait for the DOM ready event by creating a new image outside the DOM context.

https://www.pivotaltracker.com/story/show/116162145

Teapane commented 8 years ago

:+1: LGTM (Lets try modifying the commits using semantic-release`)

martinstreicher commented 8 years ago

Should this be a feat or a fix?

Teapane commented 8 years ago

@martinstreicher does your branch need to be merged first in order for the dist files to be built correctly?

aribouius commented 8 years ago

@martinstreicher it should be a fix. I'll correct the commit message.

martinstreicher commented 8 years ago

Yes.

On Mar 22, 2016, at 4:45 PM, Tyler Long notifications@github.com wrote:

@martinstreicher https://github.com/martinstreicher does your branch need to be merged first in order for the dist files to be built correctly?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/rentpath/identity.js/pull/25#issuecomment-200017166