search

rentzsch / mach_star

code injection and function overriding for Mac OS X
254 stars 46 forks source link

Speed up allocateBranchIsland #38

Closed espindola closed 12 years ago

espindola commented 12 years ago

We are using mach_override at mozilla and noticed that allocateBranchIsland was really slow in some cases (https://bugzilla.mozilla.org/show_bug.cgi?id=773903).

In the process of figuring out what was going on I also simplified the code a bit. P.S.: some of the patches look a lot smaller with diff -b

rentzsch commented 12 years ago

I'm not a fan of early returns in the general case, but I'll let this one slide since the rest of this looks so good :)

nico commented 12 years ago

When we updated mach_override to HEAD in chromium (to pick up 34048d938af230c2c801e02d6c312f856ac4150a), it stopped working for us (http://crbug.com/141707). It's somewhat likely that something in this pull request is to blame.

rentzsch commented 12 years ago

Yup, I rebooted mach_override into its own repo and got tests running again, and for whatever reason these changes cause the tests to fail. I've backed out the changes.

@espindola please try to repro the test failures with these changes on your end, make them pass and then resubmit your pull request via the mach_override repo.