search

renyard / validity

A Google Chrome extension for validating HTML.
https://chrome.google.com/webstore/detail/bbicmjjbohdfglopkidebfccilipgeif
Apache License 2.0
90 stars 22 forks source link

Unable to save Custom Validator URL #32

Closed magnetikonline closed 10 years ago

magnetikonline commented 10 years ago

Hello,

love your work on this extension - and great to see an update in 2014!

Sadly, I can no longer change/set a custom validator URL like previous versions.

The Enable for Specified Hosts/Automatically Validate Hosts both work and save settings - but anything entered into custom validator URL will not stick/save.

Noted that viewing web developer console shows a JavaScript error of Uncaught TypeError: undefined is not a function chrome-extension://bbicmjjbohdfglopkidebfccilipgeif/options/options.js:43 assuming this is related as it's around the lines for persisting the validator URL value.

Thanks

Pete

renyard commented 10 years ago

Hi Pete

Thanks for reporting the issue. From a very brief lunchtime check of the code, it looks like this issue is with the options page pulling the value back from storage, rather than the saving it. So changes to the validator URL are successfully saved and can be used, but will appear blank next time you open the options UI.

Assuming there's nothing more going on here, I should be able to get an update out in the next day or so. In the meantime, the custom validator functionality should still be working in 2.0.1 (with the above caveat), please let me know if this is not working for you.

magnetikonline commented 10 years ago

Thanks @renyard - you are correct (now I have double checked) - I can save/change the URL value and it's reflected in the URL that is used for the check - just can't see the current value.

Was going to try picking apart the extension and hopefully produce a PR - but sounds like you are on the ball.

Massive fan of this extension - the custom checker URL option is really handy too - using it with my (warning - shameless plug) W3C validator Docker image. Keep up the great work.

renyard commented 10 years ago

I've just made the fix in 2.0.2, which will be rolling out to the Web Store shortly.

Thanks for the kind words, if you've not already done so, I'd really appreciate a review on the Web Store.

Docker sounds like a great way to run the validator locally too.

magnetikonline commented 10 years ago

Excellent! Thanks.

Have already reviewed - infact I'm still the first/top comment/review (ordered by "helpful") in the app store - review given just over a year ago :+1:

EDIT: well that was quick - version 2.0.2 on Google App store - working a treat now.