renyard / validity

A Google Chrome extension for validating HTML.
https://chrome.google.com/webstore/detail/bbicmjjbohdfglopkidebfccilipgeif
Apache License 2.0
90 stars 22 forks source link

Wrong type of message #80

Closed chefranov closed 1 year ago

chefranov commented 2 years ago

When I check my page I got errors in the extension:

image

But if I check it on w3c validator site I got "Info" (not error).

image

Can you change type of message from Error to Info?

UPD: PR with fixes - #81

peter-neumann-dev commented 2 years ago

+1 essential I would be happy too 🙏

chefranov commented 2 years ago

I think @renyard no longer supports this extension :(

peter-neumann-dev commented 2 years ago

It seems so, unfortunately, I don't know a solution to fix that myself.

chefranov commented 2 years ago

It's easy to fix, but then need to build and use this extension only locally (not from store)

renyard commented 2 years ago

Thanks for reporting this. The extension is not under active development, but I’m happy to release bug fixes.

It was the intention to take the log level into account and I’m pretty sure this used to work. I’ve not had a chance to dig into it, so I’m not sure why that’s not working anymore. @chefranov If you have a fix, please do raise a PR and I will test and release to the store as soon as I can.

chefranov commented 2 years ago

@renyard check PR please - #81

chefranov commented 2 years ago

In Chrome by default you can't see Info messages. If want to see it you need to mark Info from dropdown.

image

chefranov commented 2 years ago

@renyard did you get a chance to check PR?

renyard commented 2 years ago

@chefranov Looks good from the PR, thanks for submitting it. I’ve not had a chance to test and build it for release yet though. I hope to get some time to sort that out over the weekend. I’ll update here once it’s been released to the store.

renyard commented 2 years ago

I've just landed the PR and submitted to the Chrome Web Store. All going well, it should start rolling out to users once it's been approved in the next couple of days.

@chefranov Thanks again for submitting this PR, it's much appreciated by myself and Validity users. 🎉

I'll leave this ticket open until we've confirmed that it's been released to the store.

chefranov commented 2 years ago

Appeared in the store. For me works fine. @peter-neumann-dev can you check from your side?

peter-neumann-dev commented 2 years ago

@chefranov Yes, it's working fine! Thank you, both 👏