search

renyuneyun / Easer

User-defined explicit automation for Android
https://renyuneyun.github.io/Easer/
GNU General Public License v3.0
805 stars 92 forks source link

Add Airplane Mode USource #451

Closed mvn23 closed 2 years ago

mvn23 commented 2 years ago

Add Airplane Mode USource to be able to detect changes in the Airplane Mode setting.

mvn23 commented 2 years ago

Just saw that issue #425 is related.

renyuneyun commented 2 years ago

Thanks for the PR(s)! Apologize, I'm quite busy recently. But I'll try to review them and get back to you today (or as soon as possible...).

renyuneyun commented 2 years ago

It generally looks great :) I left a few suggestive comments. Depending on your availability, let me know whether you would like to fix them now or not.

(Edit:) I found some issues that had better be resolved before merging. Nothing functional. Let me know your thoughts.

Other than that, I think it's ready to be merged.

mvn23 commented 2 years ago

Thank you for the feedback. I basically copied another skill and adjusted it for my needs so there may indeed be some code in there that is no longer relevant. I will look into all suggestions and update the PR over the next few days.

The same applies to #452, which is basically a copy of this PR with different functionality so it will indeed need similar changes as you noticed already.

renyuneyun commented 2 years ago

Thanks for the changes! It looks good to me. Would you like to squash the commits yourself (and maintain a sensible commit history), or could I squash them as one commit?

mvn23 commented 2 years ago

You can squash and merge whenever you consider the code ready to go! Same goes for the other PRs.

renyuneyun commented 2 years ago

Great! Merged :) Will try to make it appear in the nearest possible release.