search

renz45 / mandrill_mailer

A small gem for sending Mandrill template emails
260 stars 84 forks source link

Ruby 3.0.0 support #142

Closed berkos closed 3 years ago

berkos commented 3 years ago

👋 Ruby 3.0.0 does not make automatic conversion on keyword arguments into a Hash anymore.

Instead we need to specific pass keyword arguments with the ** operator.

Note: For a reason CI outcome is not being displayed to Github. It might be related with PR being draft at some point.

berkos commented 3 years ago

Hi @olivierlacan, @renz45 It would be great if I can have a review on this PR. 🙏

olivierlacan commented 3 years ago

Hi @olivierlacan, @renz45 It would be great if I can have a review on this PR. 🙏

So sorry for the delay. Looks like we're going to have to migrate to GitHub Actions or Circle CI since Travis is moribond.

olivierlacan commented 3 years ago

@berkos Migrated the test suite to GitHub Actions so you can hopefully have test feedback on this PR: https://github.com/renz45/mandrill_mailer/runs/1916327693?check_suite_focus=true

olivierlacan commented 3 years ago

As I result I recommend you rebase master so GitHub Actions CI runs on this PR, you'll likely have to add 3.0 to the version matrix here: https://github.com/renz45/mandrill_mailer/blob/master/.github/workflows/tests.yml

berkos commented 3 years ago

Hi @olivierlacan Sorry for the delay. It should be addressed now. 🙂

olivierlacan commented 3 years ago

Thanks so much for working on this @berkos!

olivierlacan commented 3 years ago

@berkos Got the 1.8.0 release ready to go on the master branch (which we need to rename soon) but I don't have release powers so I asked @renz45 to either release himself or give me superpowers.

berkos commented 3 years ago

@berkos Got the 1.8.0 release ready to go on the master branch (which we need to rename soon) but I don't have release powers so I asked @renz45 to either release himself or give me superpowers.

Thanks so much for doing this @olivierlacan, @renz45 . It would be great if you can ping us when it's released so we can point back to Rubygems.

olivierlacan commented 3 years ago

@berkos Actually Adam gave me release rights so I'll get that done today. No worries. :-)

olivierlacan commented 3 years ago

@berkos Pushed: https://rubygems.org/gems/mandrill_mailer/versions/1.8.0 🎊