search

renzmann / treesit-auto

Automatic installation, usage, and fallback for tree-sitter major modes in Emacs 29
GNU General Public License v3.0
353 stars 27 forks source link

Add more ts mode from tree-sitter-module #86

Closed sebastiaanspeck closed 3 months ago

sebastiaanspeck commented 5 months ago

Supersedes #42

sethidden commented 5 months ago

Could you please add Vue as well? ext is .vue

parser (also used in nvim-treesitter: https://github.com/nvim-treesitter/nvim-treesitter/blob/7eeb26e69cd923f4ebc2e708a6acf40777d4b157/README.md?plain=1#L427) https://github.com/tree-sitter-grammars/tree-sitter-vue

https://github.com/theschmocker/vue-ts-mode https://github.com/8uff3r/vue-ts-mode

sebastiaanspeck commented 5 months ago

Could you please add Vue as well? ext is .vue

parser (also used in nvim-treesitter: nvim-treesitter/nvim-treesitter@7eeb26e/README.md?plain=1#L427) tree-sitter-grammars/tree-sitter-vue

theschmocker/vue-ts-mode 8uff3r/vue-ts-mode

Added in a8c681b (#86)

zyxir commented 4 months ago

Could you please add Scala as well? I'm surprised to see such a popular language missing from the list.

sethidden commented 4 months ago

@renzmann Would it be ok to merge to main? The PRs from https://github.com/renzmann/treesit-auto/pull/42#issuecomment-1769802364 are closed

sebastiaanspeck commented 4 months ago

Could you please add Scala as well? I'm surprised to see such a popular language missing from the list.

Added in e169c5c (#86)

zyxir commented 4 months ago

@sebastiaanspeck I'm sorry that I have made a mistake. The extension of Scala files are actually either .scala or .sbt. The correct extension regular expression would be \\.\\(scala\\|sbt\\)\\'. Could you please fix the :ext attribute? Thanks!

sebastiaanspeck commented 4 months ago

@sebastiaanspeck I'm sorry that I have made a mistake. The extension of Scala files are actually either .scala or .sbt. The correct extension regular expression would be \\.\\(scala\\|sbt\\)\\'. Could you please fix the :ext attribute? Thanks!

Thank you for providing the feedback. I am not known with Scala so I just relied on Google 😄 The next time, you could also add a suggestion as a comment to the PR. That way we could easier apply suggestions like these.

sebastiaanspeck commented 3 months ago

@renzmann any chance this can be merged? And maybe take a look at the other PR’s as well :)