renzuzu / renzu_nitro

Fivem Advanced Vehicle Nitro System - 50Shots upto 200Shots of NOS Kit
38 stars 14 forks source link

Review #11

Open iSentrie opened 1 year ago

iSentrie commented 1 year ago

I have tested resource and this is what I found:

  1. On purge there are screen effects which should not show up.
  2. Smoke or whatever it is gets cut off instead of vaporing in air.
  3. If you hit Shift+W and the same time that smoke will show instead of nitro flames.
  4. If you are not hitting W while driving and using nitro, it should activate purge not a nitro flames.
  5. If you spam Shift errors will popup and will stay even if you will use it normally without spamming. image

https://user-images.githubusercontent.com/29688478/196724426-2f1d50e8-f1e4-4cad-9f78-7d4df6747e44.mp4

renzuzu commented 1 year ago

i just tweak the client and probably solve the 1-4. the # 5 issue is i cant replicated by just spamming SHIFT. probably i fixed it on 1-4

iSentrie commented 1 year ago

Yes, indeed much better and no errors. :) Next what I would do is adjusting purge itself, from tires it doesn't look very well and the amount of it is a bit too much, isn't?

iSentrie commented 1 year ago

did some tests, you can check it out

local carEngine = GetEntityBoneIndexByName(vehicle, 'engine')
purge1 = StartParticleFxLoopedOnEntityBone_2('ent_sht_steam', vehicle, 0.25, 0.125, 0.15, 65.0, 30.0, 0.0, carEngine, 0.75, 0, 0, 0)
purge2 = StartParticleFxLoopedOnEntityBone_2('ent_sht_steam', vehicle, -0.25, 0.125, 0.15, 65.0, -30.0, 0.0, carEngine, 0.75, 0, 0, 0)
renzuzu commented 1 year ago

yes its my new plan actually to look for better implementation of smokes or purges position.

im thinking to do a UI to edit the position. and yes with smoke color