search

reo7sp / tgbot-cpp

C++ library for Telegram bot API
http://reo7sp.github.io/tgbot-cpp
MIT License
1.02k stars 247 forks source link

Bad Request: chat not found #308

Open usadev1984 opened 5 months ago

usadev1984 commented 5 months ago

based on the documentation, my bot should be able to respond to a message without specifying the chat id if the message is in the same chat. however when i try something like the following code to respond to a message a user sent to the bot directly in dm:

const char * reply = "You're already in the chat.";
TgBot::ReplyParameters rp_params;
rp_params.allowSendingWithoutReply = true;
rp_params.messageId = ev->messageId;

bot->getApi().sendMessage(ev->chat->id, reply, nullptr, std::make_shared<TgBot::ReplyParameters>(rp_params));

i get Bad Request: chat not found. the only way around it is to provide the chat id. so for example the following works:

const char * reply = "You're already in the chat.";
TgBot::ReplyParameters rp_params;
rp_params.allowSendingWithoutReply = true;
rp_params.messageId = ev->messageId;
rp_params.chatId = ev->chat->id;

bot->getApi().sendMessage(ev->chat->id, reply, nullptr, std::make_shared<TgBot::ReplyParameters>(rp_params));

am i doing something wrong? im using the latest version of the library btw.

uralm1 commented 3 weeks ago

I confirm the problem. This is wrong api design (tgbot-cpp api, not a telegram). We can not skip optional fields in parameter structures.

Add to title: (Optional fields in Telegram parameter types classes is not optional).

I guess to use std::optional for that purpose. Or even better boost::optional, because it don't require cpp17 and integrates with boost:property_tree.