search

reonZ / pf2e-toolbelt

5 stars 4 forks source link

Target Token Helper highlights only working for some spells #16

Closed kevinhawke closed 9 months ago

kevinhawke commented 9 months ago

PF2e Toolbelt v1.29.2 Pathfinder 2e v5.11.5 Foundry VTT v11.315

When using Target Token Helper for save spells, the damage highlight doesn't always appear.

I've seen it work with: Scatter Scree, Timber, Electric Arc, Caustic Blast, Frostbite, Flourishing Flora, Floating Flame, Rime Slick

But it doesn't show up for: Puff of Poison, Grim Tendrils, Gritty Wheeze, Chilling Spray, Ignite Fireworks.

I don't see any errors in the console and I've tried making sure the spells are the latest versions from the compendiums.

reonZ commented 9 months ago

The reason is because those spells don't have their save tagged as Basic Save, which are the only saves that i can be sure of when it comes to the whole double/half/regular damage.

Even though a spell like Puff of Poison clearly works as a Basic Save when it comes to the damage part, it is not technically a Basic Save.

image

For your own convenience, you can manually check the Basic checkbox and take advantage of the module's highlighting, but there is nothing i can do about it on my end (unless i was willing to always use the highlights no matter the save type, which i am not).