reorproject / reor

Private & local AI personal knowledge management app.
https://reorproject.org
GNU Affero General Public License v3.0
6.52k stars 371 forks source link

Spell Checking #258

Open Lamer217 opened 1 month ago

Lamer217 commented 1 month ago

I've noticed that the Reor app currently does not have any spell-checking functionality. I'm wondering if this is a feature that has not yet been implemented, or if it is an intentional design choice?

Rationale: As the app is focused on taking notes, I believe that having spell-checking would be a valuable feature. Ensuring correct spelling is important for note-taking, as it enhances the readability and professionalism of the notes.

Proposal: I propose adding spell-checking functionality to the Reor app. This could be implemented as an optional feature that users can enable or disable based on their preference.

Thank you for considering this feature request.

samlhuillier commented 1 month ago

Thank you for mentioning this!

Yes this is something that we definitely can add. It was removed a couple of weeks back so that the welcome message (in English) would not just show a bunch of spelling errors to users with non-English machines.

It'll need to be added in settings as a toggle which saves the spellcheck preference in settings. Would you be interested in contributing to this feature? I'd love to see a contribution from you and I can help out where needed :)

sebastian-philipp commented 1 month ago

Maybe relates to https://github.com/reorproject/reor/issues/237 ?

weilirs commented 1 month ago

I'll see if I can help with this, would love to contribute!

samlhuillier commented 1 month ago

Just a little pointer @weilirs you'll see spellcheck was disabled in use-file-by-filepath.ts:

spellcheck: "false"
weilirs commented 1 month ago

For this feature, is it better to have a "General" page in the settings to manage preferences like this? I don't know if it is crucial enough to have a page itself like "Chunk Size".

Also, this preference needs to be added to electron store?

samlhuillier commented 1 month ago

Yes I completely agree with you although I'd suggest a different categorisation: chunk size should really be part of RAG settings and spellcheck could be under either "Editor Settings" or "General" - your call