reorproject / reor

Private & local AI personal knowledge management app.
https://reorproject.org
GNU Affero General Public License v3.0
6.82k stars 410 forks source link

Can't show formula and picture correctly #286

Open ZeroCore-Zero opened 2 months ago

ZeroCore-Zero commented 2 months ago

Describe the bug I copied my existing notes to the vault dictionary, whick contains some formulas and pictures, but when i open it in reor, it can't show correctly. Source file is here: note.zip

Expected behavior Formulas and pictures can be showed correctly

Screenshots

This is my note. image This is my source code in showed in VSCode. image This is the expected view with VSCode. image

Desktop (please complete the following information):

Additional context btw, is there any way to check application version in it? I can't find it. QAQ

tusharkaran commented 1 month ago

Working on it

tusharkaran commented 1 month ago

'@tiptap/react' this extenstion which is currently used for editor , does not support formulas and pictures , can I use some other extension ?

weilirs commented 1 month ago

'@tiptap/react' this extenstion which is currently used for editor , does not support formulas and pictures , can I use some other extension ?

Maybe you can try this one? https://tiptap.dev/docs/editor/extensions/nodes/image

tusharkaran commented 1 month ago

Ohk , thank you @weilirs . will check this one

samlhuillier commented 1 month ago

Or perhaps this extension is the one we're after: https://tiptap.dev/docs/editor/extensions/functionality/mathematics

Although it looks like it's paid. If you think this is what we're after, I'll look into sorting out a tiptap pro subscription @tusharkaran

tusharkaran commented 1 month ago

image

IS this good ? But this is pro extension . Apart from that this does not support image

tusharkaran commented 1 month ago

for images , https://tiptap.dev/docs/editor/extensions/nodes/image

This does not have drag and drop functionality . Although ordering of image can change by dragging. It has a button which , on click it asks the URL of image , then it gets added , as shown in the extension .

weilirs commented 1 month ago

image

IS this good ? But this is pro extension . Apart from that this does not support image

I noticed that some formulas are not displaying correctly, but others are working fine. Can you fix the ones that are broken? Regarding images, I came across this post: https://stackoverflow.com/questions/78147060/how-to-upload-inserted-images-with-image-extension-in-tiptap. Maybe you can give it a try.

tusharkaran commented 1 month ago

image Mathematics formulas are working now .

Images I not sure , not getting idea from that regference as well .

weilirs commented 1 month ago

LGTM! You can make a PR for the formula itself. Don't worry about images for now.

tusharkaran commented 4 weeks ago

https://github.com/reorproject/reor/pull/342

Raised A PR for the Formula . Please Install the Dependencies , as those were PRO Extension . so they require credential. Have mention the command and link of Extension in The PR.