reorproject / reor

Private & local AI personal knowledge management app.
https://reorproject.org
GNU Affero General Public License v3.0
6.85k stars 414 forks source link

Improve the context controls for chat window #345

Open samlhuillier opened 1 month ago

samlhuillier commented 1 month ago

Problem

Currently to customise context retrieval settings in each chat, the user has to go into a messy modal to customise each chat which does not make it easy to chat.

Video shows current experience:

https://github.com/user-attachments/assets/f029a1e5-7596-4a4b-88f1-ba1f3bf75282

Solution

All the controls in the modal should be moved to a titlebar section immediately visible when a user opens a new chat:

The titlebar should either be at the top of the chat window or at the bottom just above the chat input field. It should also disappear as soon as the first chat message is submitted.

See src/components/Chat/Chat.tsx to get started. Feel free to comment below with questions or other ideas šŸ˜€

Manas-Kenge commented 1 month ago

Hey There! I am trying to setup the repo locally to solve this issue but I am running into LanceDB Error on Windows. Even after referring the docs the error still persists. I was wondering if you could help.

sarthakladhwe commented 1 month ago

Hi @samlhuillier, I see that there's some interest in this issue, but it's not currently assigned to anyone. I've started looking into this issue and currently planning on how to resolve it. Iā€™d love to help out with it. Is it okay if I work on this? Thanks!

weilirs commented 1 month ago

Hi @samlhuillier, I see that there's some interest in this issue, but it's not currently assigned to anyone. I've started looking into this issue and currently planning on how to resolve it. Iā€™d love to help out with it. Is it okay if I work on this? Thanks!

Anyone can work on this issue, you don't need to be assigned to work on it.

weilirs commented 1 month ago

Hey There! I am trying to setup the repo locally to solve this issue but I am running into LanceDB Error on Windows. Even after referring the docs the error still persists. I was wondering if you could help.

You can open an issue and post more details.

samlhuillier commented 1 month ago

It's best if we don't duplicate work! And there's plenty of other cool things to work on!

@Manas-Kenge & @sarthakladhwe could you each confirm if you want to/have started working on this issue?

Also @Manas-Kenge what error message are you seeing with lance db?

joseplayero commented 1 month ago

/bounty $60

algora-pbc[bot] commented 1 month ago

šŸ’Ž $60 bounty ā€¢ reorproject

Steps to solve:

  1. Start working: Comment /attempt #345 with your implementation plan
  2. Submit work: Create a pull request including /claim #345 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to reorproject/reor!

Add a bounty ā€¢ Share on socials

Attempt Started (GMT+0) Solution
šŸŸ¢ @sarthakladhwe Aug 17, 2024, 6:55:40 AM #361
šŸŸ¢ @onyedikachi-david Aug 28, 2024, 12:43:14 PM #388
šŸŸ¢ @aybanda Sep 6, 2024, 1:51:32 PM WIP
sarthakladhwe commented 1 month ago

Hi @samlhuillier, I'm working on it. I shall create a pull request soon.

My approach is to position the context settings just above the chat input field. I believe this placement offers better accessibility and visibility for users. Additionally, instead of using popups or tooltips for changing the settings, I suggest integrating the settings directly into the titlebar for a more streamlined and intuitive user experience. I will provide screenshots to illustrate this idea soon. However, if it is preferred to have a popup/tooltip, I am happy to implement that as well.

sarthakladhwe commented 1 month ago

/attempt #345

joseplayero commented 1 month ago

@sarthakladhwe this approach sounds reasonable to me. as long as all the same settings in the modal can be edited in a nice intuitive ui + a couple of extra settings like llm (and more in the future) then please get started on a PR :)

sarthakladhwe commented 1 month ago

Hi @samlhuillier @joseplayero, I have linked a draft pull request for this issue. I would love some thoughts on the current approach. Any changes are welcome! :)

onyedikachi-david commented 3 weeks ago

/attempt #345

Algora profile Completed bounties Tech Active attempts Options
@onyedikachi-david 5 bounties from 2 projects
JavaScript, Shell
Cancel attempt

Just queuing up šŸ™‚

joseplayero commented 2 weeks ago

feel free to attack the issue @onyedikachi-david i've re-assigned you to the task!

aybanda commented 1 week ago

@joseplayero /attempt #345

Algora profile Completed bounties Tech Active attempts Options
@aybanda 1 bounty from 1 project
Cancel attempt
joseplayero commented 1 week ago

i will be taking on this task. apologies to all those who wanted to contribute, this requires some thought and extra refactoring. there will be more issues with bounties very soon :)