reorproject / reor

Private & local AI personal knowledge management app.
https://reorproject.org
GNU Affero General Public License v3.0
6.83k stars 413 forks source link

Fix newline issue in markdown editor #362

Open joseplayero opened 3 weeks ago

joseplayero commented 3 weeks ago

Problem

When a user types newlines into the editor, closes the file and re-opens it, those newlines disappear. Only holding shift while pressing enter preserves the newlines and its because the markdown file gets saved with backslashes \ where the newlines are.

Solution

Fix the issue without needing backslahses and ideally without conditional logic manually parsing particular characters but with changes to the extension settings/config - like tiptap markdown.

We should look to basically have the same behaviour as Obsidian which saves newlines to markdown without backslashes and then opens those files with newlines correctly placed in the editor.

joseplayero commented 3 weeks ago

/bounty $65

algora-pbc[bot] commented 3 weeks ago

💎 $65 bounty • reorproject

Steps to solve:

  1. Start working: Comment /attempt #362 with your implementation plan
  2. Submit work: Create a pull request including /claim #362 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to reorproject/reor!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🔴 @Mubashirshariq Aug 23, 2024, 6:02:06 AM WIP
🔴 @jkcs Aug 26, 2024, 8:22:21 AM WIP
🟢 @govindup63 Aug 26, 2024, 2:16:01 PM WIP
🟢 @milaiwi Sep 7, 2024, 4:33:41 AM #399
Mubashirshariq commented 3 weeks ago

@joseplayero can i get this assigned,if nobody is working on it!

milaiwi commented 3 weeks ago

@joseplayero Can you assign this to @Mubashirshariq. I'm currently busy with other stuff right now.

joseplayero commented 2 weeks ago

Absolutely you're assigned @Mubashirshariq !

Mubashirshariq commented 2 weeks ago

/attempt #362

Algora profile Completed bounties Tech Active attempts Options
@Mubashirshariq 2 bounties from 2 projects
JavaScript, TypeScript,
HTML
Cancel attempt
Mubashirshariq commented 2 weeks ago

@joseplayero i was working on this and i debugged it got the follwoing results that in html all the \ are getting converted to br tag, and i have added the newline when a user presses enter

jkcs commented 2 weeks ago

Can I give this a try?

joseplayero commented 2 weeks ago

Yes please go ahead @jkcs :)

govindup63 commented 2 weeks ago

/attempt #362

amochuko commented 2 weeks ago

Am available to give it a go.

govindup63 commented 2 weeks ago

if this issue isn't resolved can i get assigned to it coz I made an attempt earlier

joseplayero commented 1 week ago

please both try it @govindup63 @amochuko

joseplayero commented 1 week ago

Unassigned @amochuko & @govindup63 as looks like no progress.

@milaiwi now assigned!

milaiwi commented 5 days ago

/attempt #362

Algora profile Completed bounties Tech Active attempts Options
@milaiwi 2 reorproject bounties
TypeScript, Go,
Python
Cancel attempt
algora-pbc[bot] commented 5 days ago

💡 @milaiwi submitted a pull request that claims the bounty. You can visit your bounty board to reward.