search

reorproject / reor

Private & local AI personal knowledge management app for high entropy people.
https://reorproject.org
GNU Affero General Public License v3.0
7.21k stars 445 forks source link

feat(writing assistant): auto-scroll and follow-up #447

Closed weilirs closed 1 month ago

weilirs commented 1 month ago

442

weilirs commented 1 month ago

thanks for working on this. looks mostly good to me.

the only thing i think needs improvement is the conversation history:

  1. it should be rendered inside a reactmarkdown component
  2. the user message shows the full prompt, not just what they typed in the input field
  3. i'm not sure about the chat kind of ui in conversation history that shows messages in chat bubbles because this is writing assistant not chat:
  • one idea i had for the ui was that instead of chat history, for each follow up we could render it by itself (without showing old follow ups) and then have back and forth navigation buttons at the top of the writing assistant to navigate between past follow ups

Please look at the latest commit. It is a WIP but is it the UI we want?

joseplayero commented 1 month ago

yes i think that's what i had in mind. i'd suggest that no need to show the user messages at all and only show assistant message for V1.

weilirs commented 1 month ago

yes i think that's what i had in mind. i'd suggest that no need to show the user messages at all and only show assistant message for V1.

In the latest commit it only shows the assistant message. If this is good then I'll clean things up and finalize it.

joseplayero commented 1 month ago

yes it look good to me :)

i'd propose to remove the "Assistant: " thing and move buttons (apart from next and previous btns) to the bottom of the component

weilirs commented 1 month ago

please take a look at the latest commit