reown-com / a2

An Asynchronous Apple Push Notification (apns2) Client for Rust
MIT License
150 stars 52 forks source link

Remove bunch of allocations from the builders #25

Closed pimeys closed 6 years ago

pimeys commented 6 years ago

This breaks the api a bit if somebody used Strings. Now we allocate a new string only when creating the result JSON. To have this I needed remove the implementation for Service trait to have somehow sane lifetime requirements for the Client. If anybody depended on the Service, I'm not merging this right away and need to think of something.

This should bump the version to 0.3.0 when released, but first we're running some tests how much faster we get with these changes.

h0x @dbrgn