search

reown-com / a2

An Asynchronous Apple Push Notification (apns2) Client for Rust
MIT License
153 stars 54 forks source link

Implement fmt::Display for ErrorReason #28

Closed jonas-schievink closed 6 years ago

jonas-schievink commented 6 years ago

Previously, the only way to get any information out of this was via Debug, which is bad for user-facing errors.

pimeys commented 6 years ago

Hi, sorry for late reply. We've had a bit of a catastrophy with our company and had no time to check github. I'll merge this. Thank you!

jonas-schievink commented 6 years ago

Jeez, that doesn't sound good. I hope it all works out!

pimeys commented 6 years ago

Haha, yeah I guess. Taking break until next year, but I guess not working with Rust professionally anymore...

So our company went down, but soon we'll open source the rest of our stack, including a consumer that sends all different kind of pushes. Stay tuned!

dbrgn commented 6 years ago

Oh no, that's really bad to hear :slightly_frowning_face: But great that you can open source your stack.

pimeys commented 6 years ago

Yeah, well jobs are easy to find in Berlin. I just need to find more open source work with Rust in the future. Also I have no Apple devices anymore, so would appreciate if somebody who holds an Apple device with a valid certificate/token would be able to test changes in the future. Especially if the changes touch the client, and I guess we should refactor when async/await gets stable!