Open HarryET opened 1 year ago
Using impl Into<String>
allows you to accept any type that can be converted into a String
. This can be more flexible than using &str
with a lifetime, because it allows the caller to pass in a variety of types, including owned Strings, &String, &str,
and even types like String, Vec,
and Box
that implement the Into
trait.
Yes, that is why we have this issue open to make that change, is it something you want to do @MohammadAbuzar945?
@HarryET This would imply removing the borrow parameter 'a
and moving to using String
in Payload
correct? https://github.com/WalletConnect/a2/blob/0b29470b6d559a9b3ae8d7136151b0a8e32f60b3/src/request/payload.rs#L10
@HarryET This would imply removing the borrow parameter
'a
and moving to usingString
inPayload
correct?
Correct, it should use String
internally and all params should be S: Into<String>
as a generic
Stop using
&str
with lifetime for the params and instead useimpl Into<String>