Closed Mstrodl closed 1 year ago
@HarryET Bumping this, since it seems like you're the maintainer
@HarryET Bumping this, since it seems like you're the maintainer
Hey @Mstrodl, yeah I'm maintaining it! I'm OOO for the rest of this week but will do a proper review next week, thanks for the PR 😄
@HarryET Made some changes... Let me know what you think!
@HarryET Made some changes... Let me know what you think!
Very nice, makes .set_critical()
easier to read, do we have tests for that custom serde seralizer/deseralizer?
@HarryET Made some changes... Let me know what you think!
Very nice, makes
.set_critical()
easier to read, do we have tests for that custom serde seralizer/deseralizer?
Yes, because everything goes through PayloadLike
, there shouldn't be any difference. I also have an example of the full thing in the docs, but it's not run automatically because it would need credentials
@HarryET Made some changes... Let me know what you think!
Very nice, makes
.set_critical()
easier to read, do we have tests for that custom serde seralizer/deseralizer?Yes, because everything goes through
PayloadLike
, there shouldn't be any difference. I also have an example of the full thing in the docs, but it's not run automatically because it would need credentials
Okay, a small test case might be nice but if it's already included by proxy that should be ok
Any news on those reviews?
Description
Serialize
implementations for the APNS payload. This means users can add custom fields inside theaps
key (a bad idea for new software, but unfortunately we're kinda stuck with old apps that read custom data from weird places)How Has This Been Tested?
cargo test
passesaps
.Due Dilligence
Not sure if I'm filling these out correctly:
PayloadLike
. Maybe we could have dummy functions that replicate the functionality on the struct itself? Not sure if that'll work or if it's worth doing though)Would really love for someone to code review this and let me know if there's anything I can improve on!