reown-com / appkit

The full stack toolkit to build onchain app UX
https://reown.com/appkit
Apache License 2.0
4.93k stars 1.41k forks source link

[bug] Bitget wallet is not detected #1389

Closed m00n620 closed 1 year ago

m00n620 commented 1 year ago

Link to minimal reproducible example

https://web3modal.com

Summary

Bitget Wallet(formerly Bitkeep) is not being detected in web3modal V3. I believe it's because current web3modal is checking window.ethereum.isBitKeep instead of window.bitkeep.ethereum.

List of related npm package versions

"@web3modal/wagmi": "^3.0.2"

glitch-txs commented 1 year ago

This is not planned for v3, we are moving towards EIP-6963 instead. Actually the last version of v3 already supports EIP-6963 which will detect your wallet if (it's installed) automatically and it's going to be shown on top of the modal. I would highly suggest integrating the protocol. Some major wallets already support this EIP and we have a dapp for testing it. https://github.com/WalletConnect/EIP6963