[bug] vite-react-ts only works with yarn

francesco-gaglione commented 1 year ago

Link to minimal reproducible example

create-wc-dapp

Summary

Hi all, I used create-wc-dapp to reproduce the issue, and there with a blank new project created with create-wc-dapp the issue persist. I created a react project (not next). The issue is the classic no wagmi config found into the createWeb3Modal() imported from @web3modal/wagmi/react.

After hours and hours spent trying to understand what the problem was, just to try I used yarn and magically everything started working. At that point I also started trying other package managers and I tried pnpm and bun and with these the error reappears.

The result is that it only work with yarn, and it is a bit confusing since in a previous issue on the web3modal v2 opened by me one of the dev (I think) said that yarn was not well supported. Now on v3 only yarn works. Can you please check it? And in case of solution can you say how to solve it?

Note: in title I placed vite-react-ts because the same issue is on a different project based on vite-react-ts, but it dosn't matter since I replicated the issue with create-wc-dapp using react template

List of related npm package versions

"dependencies": {
    "@web3modal/wagmi": "^3.1.0",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "rollup-plugin-visualizer": "^5.9.2",
    "viem": "1.16.6",
    "vite": "^4.5.0",
    "wagmi": "1.4.4"
  },
 "devDependencies": {
    "@types/react": "^18.2.33",
    "@types/react-dom": "^18.2.7",
    "@typescript-eslint/eslint-plugin": "^6.0.0",
    "@typescript-eslint/parser": "^6.0.0",
    "@vitejs/plugin-react": "^4.0.3",
    "autoprefixer": "^10.4.16",
    "eslint": "^8.45.0",
    "eslint-plugin-react-hooks": "^4.6.0",
    "eslint-plugin-react-refresh": "^0.4.3",
    "postcss": "^8.4.31",
    "react-router-dom": "^6.17.0",
    "tailwindcss": "^3.3.5",
    "typescript": "^5.0.2"
  }

node version: 20.5.1 bun version: 1.0.7 pnpm version: 8.6.12 yarn version: 1.22.19

boidushya commented 1 year ago

Hey @francesco-gaglione , could you specify your npm version too? I tried reproducing this locally with npm v10.2.3 and node 21.1.0 and was able to set it up without getting the error you mentioned For context: I'm using create-wc-dapp v1.16.0 with react + wagmi + npm (create-wc-dapp@latest) Could you recheck on your end as well with these configs ^^

For additional context: selecting yarn as package manager deletes package-lock.json from here during the install step.

francesco-gaglione commented 1 year ago

npm version is 9.6.3

in all cases the problem is not a specific version. I continued to investigate and it occurs randomly. We have some projects where only pnpm works, other projects where only yarn works. In still others (all those where there is a next.js frontend with ssr) no package manager works and randomly after several installs it starts working without changing any dependencies. My suspicion is that there is some problem with peerDependencies being misinterpreted and installed incorrectly.

boidushya commented 1 year ago

At the moment, doesn't seem like theres enough information to debug this properly

francesco-gaglione commented 1 year ago

What information can be useful for analyzing the problem?

reown-com / appkit