reown-com / appkit

The full stack toolkit to build onchain app UX
https://reown.com/appkit
Apache License 2.0
4.91k stars 1.4k forks source link

[bug] GET return 404 from https://rpc.walletconnect.com/v1/profile/reverse/xxx #2347

Open tuannx opened 4 months ago

tuannx commented 4 months ago

Link to minimal reproducible example

https://web3modal-mre.vercel.app/

Summary

Create new react ts with web3modal ethers.

Connect to smartwallet base testnet: chainId: 84532, name: "Base Sepolia", currency: "ETH", explorerUrl: "https://sepolia-explorer.base.org", rpcUrl: "https://sepolia.base.org",

After login got error 404: GET https://rpc.walletconnect.com/v1/profile/reverse/0x14338152970B7B9A24092382e4B2e9B78Ba13D65?projectId=28e14a91201028f94cee88eb9da0a227 404 (Not Found)

Potential problem: Smartwallet create smart contract address instead of normal wallet address.

smartwallet address on Base testnet: 0x14338152970B7B9A24092382e4B2e9B78Ba13D65

code: https://github.com/tuannx/web3modal-mre

List of related npm package versions

"@testing-library/jest-dom": "^5.17.0",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
"@types/jest": "^27.5.2",
"@types/node": "^16.18.97",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"@web3modal/ethers": "^4.2.3",
"ethers": "^6.12.1",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-scripts": "5.0.1",
"typescript": "^4.9.5",
"web-vitals": "^2.1.4"
linear[bot] commented 4 months ago

APKT-543 [bug]

peteAhn commented 4 months ago

Same here

kr-arunp commented 4 months ago

same issue here

VajraK commented 3 months ago

also, on mainnet!

chris13524 commented 3 months ago

Is something not functioning properly or are you guys just seeing this error in the console?

whichghost commented 3 months ago

it happens on https://lab.web3modal.com/ with rabby wallet on chrome

ZachHandley commented 3 months ago

So, as of now, it's been 5 weeks with seemingly no activity or assigned user, I messaged about it in Discord and was ignored, is it super borked, not a priority, gonna take another week, can we get some communication here?

chris13524 commented 3 months ago

@ZachHandley I replied to the thread above

Is something broken or not-functional with the UI or SDK?

Or is the concern only that there are errors in the console? Our API returns 404s when things don't exist, but this is expected/normal behavior.

ZachHandley commented 3 months ago

Yeah my balances don't show, which isn't a gigantic deal, though it definitely should be fixed cause it's not very clear (but it says I have money here, so do I need to transfer in? idk users are not the smartest), but I'm also curious what the profile is (the image for instance) and how to reduce the 2-4 errors in the console

my bad. I did not see your response, at all, sorry for the momentary crusade lmao

chris13524 commented 3 months ago

I loaded the example from the issue description and my balance displays fine:

image

/profile is for loading information about ENS name registrations, it is unrelated to the balance request.

@ZachHandley can you please open up a new issue/discussion for your balance not showing issue and include a MRE?


We are planning a new API revision that will remove the use of 4xx's across our APIs for normal conditions, which will avoid the console errors seen here. Tracking issue here.

Closing this issue as it seems like the problem is exclusively the console errors and no functionality is broken.

glitch-txs commented 3 months ago

Closing this issue as it seems like the problem is exclusively the console errors and no functionality is broken.

AppKit is still sending an invalid request so I think still needs fixing if I'm not mistaken.

chris13524 commented 3 months ago

AppKit is still sending an invalid request so I think still needs fixing if I'm not mistaken.

@glitch-txs please elaborate on what is broken. Why do you think it is sending an invalid request?

Victor-Salomon commented 3 months ago

@chris13524 @glitch-txs I'm following up with the current issue.

It's actually related to the issue https://github.com/WalletConnect/web3modal/issues/1888 I'm expecting a response when possible. Thanks a lot for your help in advance. I'm happy to highlight or elaborate on the issue if needed.

Thanks!

theMacAli commented 1 month ago

i'm having the same issue. Any update or solution?