enesozturk commented 3 weeks ago

Description

For plain JS users we are not providing expected listeners as we do with the hooks (useAppKitAccount and useAppKitNetwork). This PR introduces changes to AppKit client to have the same listener for plain JS users to subscribe account and network state.

*The testing of these will be handled in another PR specific to CDN updates

Type of change

[x] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

[ ] Code in this PR is covered by automated tests (Unit tests, E2E tests)
[x] My changes generate no new warnings
[x] I have reviewed my own code
[ ] I have filled out all required sections
[ ] I have tested my changes on the preview link
[ ] Approver of this PR confirms that the changes are tested on the preview link

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 9:49am
appkit-wagmi-cdn-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 9:49am
vue-wagmi-example	❌ Failed (Inspect)			Oct 31, 2024 9:49am
web3modal-gallery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2024 9:49am

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 8b0ef1ffc7ae2c6abb925608439e222b0e1c4336

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages

| Name | Type | | ------------------------------ | ----- | | @reown/appkit | Patch | | @apps/demo | Patch | | @apps/gallery | Patch | | @apps/laboratory | Patch | | @reown/appkit-adapter-ethers | Patch | | @reown/appkit-adapter-ethers5 | Patch | | @reown/appkit-adapter-polkadot | Patch | | @reown/appkit-adapter-solana | Patch | | @reown/appkit-adapter-wagmi | Patch | | @reown/appkit-utils | Patch | | @reown/appkit-cdn | Patch | | @reown/appkit-common | Patch | | @reown/appkit-core | Patch | | @reown/appkit-experimental | Patch | | @reown/appkit-polyfills | Patch | | @reown/appkit-scaffold-ui | Patch | | @reown/appkit-siwe | Patch | | @reown/appkit-siwx | Patch | | @reown/appkit-ui | Patch | | @reown/appkit-wallet | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 weeks ago

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	345.47%	4442 / 18505
🔵	Statements	345.47%	4442 / 18505
🔵	Functions	370.3%	367 / 1080
🔵	Branches	466.63000000000005%	673 / 1374

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
packages/appkit/src/client.ts	75.82%	75.78%	84.14%	75.82%	92-93, 112-113, 116-117, 120-121, 124-127, 130-133, 136-137, 166-173, 175-177, 180-187, 282, 290, 328-331, 337, 339-341, 343-344, 347, 442, 444-446, 449-450, 452-454, 469, 471-472, 479-480, 490-491, 506-507, 510-511, 514-515, 518-519, 528-530, 536-543, 560-563, 598, 607-619
packages/core/src/utils/TypeUtil.ts	100%	100%	100%	100%

Generated in workflow #7065 for commit 8b0ef1f by the Vitest Coverage Report Action