reown-com / appkit

The full stack toolkit to build onchain app UX
https://reown.com/appkit
Apache License 2.0
4.94k stars 1.41k forks source link

fix: ethers/ethers5 `accountsChanged` handler not working #3190

Closed magiziz closed 2 weeks ago

magiziz commented 2 weeks ago

Description

There is a bug where if you connected your wallet and try to switch address manually you'll see that there is no address being shown in the connect button.

Type of change

Associated Issues

For Linear issues: Closes APKT-1393

Showcase (Optional)

Before:

https://github.com/user-attachments/assets/8c9b17b6-e55b-43c5-96b1-488d2cce2c9e

After:

https://github.com/user-attachments/assets/3709d1a0-02e3-40dc-9760-0f230b883322

Checklist

linear[bot] commented 2 weeks ago

APKT-1393 [Dogfood session] Switching account from wallet doesn't change state in Appkit for Ethers

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
appkit-laboratory πŸ›‘ Canceled (Inspect) πŸ’¬ Add feedback Nov 6, 2024 10:17am
appkit-vue-solana βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 6, 2024 10:17am
appkit-wagmi-cdn-example βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 6, 2024 10:17am
vue-wagmi-example βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 6, 2024 10:17am
web3modal-gallery πŸ›‘ Canceled (Inspect) πŸ’¬ Add feedback Nov 6, 2024 10:17am
changeset-bot[bot] commented 2 weeks ago

πŸ¦‹ Changeset detected

Latest commit: 40d74b31640236ed08b23626994578d91cc71373

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages | Name | Type | | ------------------------------ | ----- | | @reown/appkit-adapter-ethers5 | Patch | | @reown/appkit-adapter-ethers | Patch | | @apps/demo | Patch | | @apps/gallery | Patch | | @apps/laboratory | Patch | | @reown/appkit-adapter-polkadot | Patch | | @reown/appkit-adapter-solana | Patch | | @reown/appkit-adapter-wagmi | Patch | | @reown/appkit | Patch | | @reown/appkit-utils | Patch | | @reown/appkit-cdn | Patch | | @reown/appkit-common | Patch | | @reown/appkit-core | Patch | | @reown/appkit-experimental | Patch | | @reown/appkit-polyfills | Patch | | @reown/appkit-scaffold-ui | Patch | | @reown/appkit-siwe | Patch | | @reown/appkit-siwx | Patch | | @reown/appkit-ui | Patch | | @reown/appkit-wallet | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 weeks ago

Coverage Report for Coverage

Status Category Percentage Covered / Total
πŸ”΅ Lines 341.73% 4495 / 18738
πŸ”΅ Statements 341.73% 4495 / 18738
πŸ”΅ Functions 375.93% 371 / 1087
πŸ”΅ Branches 465.43000000000006% 681 / 1388
File CoverageNo changed files found.
Generated in workflow #7212 for commit 40d74b3 by the Vitest Coverage Report Action