magiziz commented 3 weeks ago

Description

When entering an email to something like "example@" and then clicking Enter, you'll see that it breaks the button styles that's on the right side of the input field.

Type of change

[ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1212

Showcase (Optional)

Before:

After:

Checklist

[ ] Code in this PR is covered by automated tests (Unit tests, E2E tests)
[x] My changes generate no new warnings
[x] I have reviewed my own code
[x] I have filled out all required sections
[x] I have tested my changes on the preview link
[ ] Approver of this PR confirms that the changes are tested on the preview link

linear[bot] commented 3 weeks ago

APKT-1212 Email input validation error breaking the styles of button

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 10:22am
appkit-vue-solana	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 10:22am
appkit-wagmi-cdn-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 10:22am
vue-wagmi-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 10:22am
web3modal-gallery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 10:22am

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: ebb0b90f186da02de26729a143b0aecf8812be56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages

| Name | Type | | ------------------------------ | ----- | | @reown/appkit-adapter-ethers5 | Patch | | @reown/appkit-adapter-ethers | Patch | | @reown/appkit-adapter-solana | Patch | | @reown/appkit-adapter-wagmi | Patch | | @reown/appkit-utils | Patch | | @reown/appkit-scaffold-ui | Patch | | @reown/appkit | Patch | | @apps/demo | Patch | | @apps/gallery | Patch | | @apps/laboratory | Patch | | @reown/appkit-adapter-polkadot | Patch | | @reown/appkit-cdn | Patch | | @reown/appkit-common | Patch | | @reown/appkit-core | Patch | | @reown/appkit-experimental | Patch | | @reown/appkit-polyfills | Patch | | @reown/appkit-siwe | Patch | | @reown/appkit-siwx | Patch | | @reown/appkit-ui | Patch | | @reown/appkit-wallet | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 weeks ago

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	341.73%	4495 / 18741
🔵	Statements	341.73%	4495 / 18741
🔵	Functions	375.93%	371 / 1087
🔵	Branches	465.43000000000006%	681 / 1388

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/scaffold-ui/src/partials/w3m-email-login-widget/index.ts	0%	0%	0%	0%	1-196
packages/scaffold-ui/src/partials/w3m-email-login-widget/styles.ts	0%	0%	0%	0%	1-3

Generated in workflow #7208 for commit ebb0b90 by the Vitest Coverage Report Action

reown-com / appkit

fix: email input breaking styles of button #3191