reown-com / appkit

The full stack toolkit to build onchain app UX
https://reown.com/appkit
Apache License 2.0
4.95k stars 1.41k forks source link

fix: readd usage of WalletConnectProvider for solana #3200

Closed zoruka closed 2 weeks ago

zoruka commented 2 weeks ago

Description

Readd the usage of WalletConnectProvider of Solana adapter injecting the UniversalAdapter provider.

Type of change

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: ddc69be08ed535927ec95c4be9482a7b50bdf6dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:00pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:00pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:00pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:00pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:00pm
github-actions[bot] commented 2 weeks ago

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 341.76% 4485 / 18718
🔵 Statements 341.76% 4485 / 18718
🔵 Functions 376.59999999999997% 372 / 1087
🔵 Branches 464.90000000000003% 680 / 1388
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/universal-adapter/client.ts 50.18% 45% 45.94% 50.18% 110-114, 132-133, 136, 143-144, 156-160, 162-215, 228-230, 239-253, 269-285, 288-294, 296-302, 312-317, 320-324, 347-352, 356-361, 368-390, 396, 398-401, 407-435, 452-460, 489-490, 492, 497-498, 520-521, 533-542, 545-548, 552-580, 619-623, 628-631, 648-649, 661-686, 703-710
Generated in workflow #7199 for commit ddc69be by the Vitest Coverage Report Action
zoruka commented 2 weeks ago

I'm closing this PR in favor of #3205 3205