reown-com / appkit

The full stack toolkit to build onchain app UX

https://reown.com/appkit

Apache License 2.0

4.94k stars 1.41k forks source link

fix: publish canary workflow. add danger rule #3204

Closed tomiir closed 2 weeks ago

tomiir commented 2 weeks ago

Description

Fix publish canary action
Add danger rule to warn about modified workflows and to fail on deleted ones

Type of change

[ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[X] Code in this PR is covered by automated tests (Unit tests, E2E tests)
[X] My changes generate no new warnings
[X] I have reviewed my own code
[X] I have filled out all required sections
[X] I have tested my changes on the preview link
[ ] Approver of this PR confirms that the changes are tested on the preview link

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 6:11pm
appkit-vue-solana	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 6:11pm
appkit-wagmi-cdn-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 6:11pm
vue-wagmi-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 6:11pm
web3modal-gallery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 6:11pm

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 98932c5314e6354a5036ddab993735a83d24ad97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 2 weeks ago

	Warnings
:warning:	Workflow file .github/workflows/publish_canary.yml has been modified

Generated by :no_entry_sign: dangerJS against 98932c5314e6354a5036ddab993735a83d24ad97

github-actions[bot] commented 2 weeks ago

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	341.46000000000004%	4482 / 18721
🔵	Statements	341.46000000000004%	4482 / 18721
🔵	Functions	375.93%	371 / 1087
🔵	Branches	465.36000000000007%	679 / 1385

File Coverage

No changed files found.

Generated in workflow #7196 for commit 98932c5 by the Vitest Coverage Report Action