tomiir commented 2 weeks ago

Description

Updates secure site url to include version parameter as `2.0.0``
Defers frame injection into the DOM until needed in email/social connection flow.
Defers resolution of frameLoadPromise to when receiving FRAME_READY event from the frame to more accurately unblock other requests to the iframe until ready, given iframe.onload did not consider the extra time required to initialize the SDK inside of the page itself.

Type of change

[ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-779

Checklist

[X] Code in this PR is covered by automated tests (Unit tests, E2E tests)
[X] My changes generate no new warnings
[X] I have reviewed my own code
[X] I have filled out all required sections
[X] I have tested my changes on the preview link
[ ] Approver of this PR confirms that the changes are tested on the preview link

linear[bot] commented 2 weeks ago

APKT-779 Magic Loaded even if not used/configured

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 9c36c4df38f17aba28ae4303e5cdef5f1a05fde1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages

| Name | Type | | ------------------------------ | ----- | | @apps/laboratory | Patch | | @reown/appkit-wallet | Patch | | @apps/demo | Patch | | @apps/gallery | Patch | | @reown/appkit-adapter-ethers | Patch | | @reown/appkit-adapter-ethers5 | Patch | | @reown/appkit-adapter-polkadot | Patch | | @reown/appkit-adapter-solana | Patch | | @reown/appkit-adapter-wagmi | Patch | | @reown/appkit | Patch | | @reown/appkit-utils | Patch | | @reown/appkit-cdn | Patch | | @reown/appkit-common | Patch | | @reown/appkit-core | Patch | | @reown/appkit-experimental | Patch | | @reown/appkit-polyfills | Patch | | @reown/appkit-scaffold-ui | Patch | | @reown/appkit-siwe | Patch | | @reown/appkit-siwx | Patch | | @reown/appkit-ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-gallery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 5:04pm
appkit-gallery-new	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 5:04pm
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 5:04pm
appkit-vue-solana	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 5:04pm
appkit-wagmi-cdn-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 5:04pm
vue-wagmi-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 5:04pm
web3modal-gallery	✅ Ready (Inspect)	Visit Preview		Nov 19, 2024 5:04pm

github-actions[bot] commented 2 weeks ago

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	335.3%	4822 / 23619
🔵	Statements	335.3%	4822 / 23619
🔵	Functions	368.54%	387 / 1430
🔵	Branches	474.44999999999993%	741 / 1721

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts	0%	0%	0%	0%	1

Generated in workflow #7443 for commit edf3fba by the Vitest Coverage Report Action