reown-com / appkit

The full stack toolkit to build onchain app UX
https://reown.com/appkit
Apache License 2.0
4.94k stars 1.41k forks source link

fix: remove browser wallet when injected provider is not detected #3220

Closed magiziz closed 1 week ago

magiziz commented 1 week ago

Description

Fixes an issue where the connect modal on mobile was always showing 'Browser Wallet' option when the injected provider wasn't detected. This happened because we included info.rdns field for the injected connector which caused the logic to not work here.

Type of change

Associated Issues

For Linear issues: Closes APKT-1432

Showcase (Optional)

This shouldn't appear if injected provider is not detected on mobile.

image

Checklist

linear[bot] commented 1 week ago

APKT-1432 [Bug] Browser Wallet is showing in all mobile web an it's falling

changeset-bot[bot] commented 1 week ago

πŸ¦‹ Changeset detected

Latest commit: c72f56225c26d6b714d16c7e9c87b0242442df58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages | Name | Type | | ------------------------------ | ----- | | @reown/appkit-adapter-wagmi | Patch | | @apps/demo | Patch | | @apps/gallery | Patch | | @apps/laboratory | Patch | | @reown/appkit-adapter-ethers | Patch | | @reown/appkit-adapter-ethers5 | Patch | | @reown/appkit-adapter-polkadot | Patch | | @reown/appkit-adapter-solana | Patch | | @reown/appkit | Patch | | @reown/appkit-utils | Patch | | @reown/appkit-cdn | Patch | | @reown/appkit-common | Patch | | @reown/appkit-core | Patch | | @reown/appkit-experimental | Patch | | @reown/appkit-polyfills | Patch | | @reown/appkit-scaffold-ui | Patch | | @reown/appkit-siwe | Patch | | @reown/appkit-siwx | Patch | | @reown/appkit-ui | Patch | | @reown/appkit-wallet | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
appkit-gallery βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 4:43pm
appkit-laboratory βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 4:43pm
appkit-vue-solana βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 4:43pm
appkit-wagmi-cdn-example βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 4:43pm
vue-wagmi-example βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 10, 2024 4:43pm
web3modal-gallery βœ… Ready (Inspect) Visit Preview Nov 10, 2024 4:43pm
github-actions[bot] commented 1 week ago

Coverage Report for Coverage

Status Category Percentage Covered / Total
πŸ”΅ Lines 340.18999999999994% 4512 / 19108
πŸ”΅ Statements 340.18999999999994% 4512 / 19108
πŸ”΅ Functions 375.96000000000004% 372 / 1097
πŸ”΅ Branches 465.5% 683 / 1397
File CoverageNo changed files found.
Generated in workflow #7311 for commit c72f562 by the Vitest Coverage Report Action