reown-com / appkit

The full stack toolkit to build onchain app UX

https://reown.com/appkit

Apache License 2.0

4.94k stars 1.41k forks source link

:fix wc deeplink issue & missing metadata #3239

Closed svenvoskamp closed 1 week ago

svenvoskamp commented 1 week ago

Description

DEEPLINK_CHOICE had an incorrect key @appkit/deeplink_choice. Changed this to the correct key and added a test to check the key
Added syncConnectedWalletInfo to store the correct wallet info. Added a test to check if this happens.

Type of change
[ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Checklist

[x] Code in this PR is covered by automated tests (Unit tests, E2E tests)
[x] My changes generate no new warnings
[x] I have reviewed my own code
[x] I have filled out all required sections
[ ] I have tested my changes on the preview link
[ ] Approver of this PR confirms that the changes are tested on the preview link

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2024 8:53am
appkit-vue-solana	🛑 Canceled (Inspect)			Nov 14, 2024 8:53am
appkit-wagmi-cdn-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2024 8:53am
vue-wagmi-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2024 8:53am
web3modal-gallery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2024 8:53am

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 57b7fce51647ef9b70038ea11d0d3554390e1ab4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 week ago

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	321.30999999999995%	4381 / 19627
🔵	Statements	321.30999999999995%	4381 / 19627
🔵	Functions	365.14000000000004%	372 / 1128
🔵	Branches	469.39%	694 / 1400

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/appkit/src/client.ts	43.49%	66.44%	71.18%	43.49%	188-189, 232-233, 236-237, 252-255, 258-261, 264-265, 294-305, 308-317, 412, 416, 423, 461-464, 470-477, 480, 568-580, 595-598, 605-606, 614-615, 630-631, 634-635, 638-639, 642-643, 651-655, 660-667, 684-687, 698-781, 783-816, 818-822, 824-845, 847-852, 854-862, 864-873, 875-895, 897-904, 906-917, 919-932, 934-937, 939-942, 947-1007, 1010-1023, 1031-1032, 1040-1144, 1149-1189, 1196-1211, 1215-1217, 1221-1236, 1241-1251, 1254-1326, 1329-1343, 1346-1358, 1370, 1385, 1400-1401, 1414-1420, 1422-1433, 1435-1442, 1464-1480, 1485-1487, 1495-1499, 1514, 1528, 1530-1531, 1536-1548, 1559, 1561-1562, 1568-1579, 1586-1587, 1597, 1599, 1620-1635, 1642-1643, 1681, 1692-1704
packages/common/src/utils/SafeLocalStorage.ts	90.9%	100%	80%	90.9%	57-60

Generated in workflow #7350 for commit 57b7fce by the Vitest Coverage Report Action