svenvoskamp commented 6 days ago

Description

Fixed an issue where MM injected browser doesn't show up on ethers

Type of change

[ ] Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #3244

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

[ ] Code in this PR is covered by automated tests (Unit tests, E2E tests)
[ ] My changes generate no new warnings
[ ] I have reviewed my own code
[ ] I have filled out all required sections
[ ] I have tested my changes on the preview link
[ ] Approver of this PR confirms that the changes are tested on the preview link

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 4:37pm
appkit-vue-solana	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 4:37pm
appkit-wagmi-cdn-example	🛑 Canceled (Inspect)			Nov 15, 2024 4:37pm
vue-wagmi-example	🛑 Canceled (Inspect)			Nov 15, 2024 4:37pm
web3modal-gallery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 4:37pm

changeset-bot[bot] commented 6 days ago

🦋 Changeset detected

Latest commit: 720ee1d5804f01e9f15e78cb3f1736cb7c9cd894

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages

| Name | Type | | ------------------------------ | ----- | | @reown/appkit-core | Patch | | @apps/demo | Patch | | @apps/gallery | Patch | | @apps/laboratory | Patch | | @reown/appkit-adapter-ethers | Patch | | @reown/appkit-adapter-ethers5 | Patch | | @reown/appkit-adapter-polkadot | Patch | | @reown/appkit-adapter-solana | Patch | | @reown/appkit-adapter-wagmi | Patch | | @reown/appkit | Patch | | @reown/appkit-utils | Patch | | @reown/appkit-cdn | Patch | | @reown/appkit-common | Patch | | @reown/appkit-experimental | Patch | | @reown/appkit-polyfills | Patch | | @reown/appkit-scaffold-ui | Patch | | @reown/appkit-siwe | Patch | | @reown/appkit-siwx | Patch | | @reown/appkit-ui | Patch | | @reown/appkit-wallet | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 6 days ago

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	321.19999999999993%	4388 / 19651
🔵	Statements	321.19999999999993%	4388 / 19651
🔵	Functions	363.4200000000001%	372 / 1134
🔵	Branches	469.5899999999999%	695 / 1400

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/core/src/controllers/ConnectorController.ts	77.55%	92.1%	75%	77.55%	31-32, 95-96, 111-112, 122-131, 187-208

Generated in workflow #7374 for commit 720ee1d by the Vitest Coverage Report Action

elix1er commented 2 days ago

please deploy to NPM @svenvoskamp

reown-com / appkit

:fix MM injected browser not showing on ethers #3250