reown-com / appkit

The full stack toolkit to build onchain app UX
https://reown.com/appkit
Apache License 2.0
4.94k stars 1.41k forks source link

fix: remove condition on SIWE sign out mapping #3286

Closed zoruka closed 21 hours ago

zoruka commented 1 day ago

Description

This PR is removing the condition for SIWE signOut call so it keeps backwards compatibility as this was not being checked before.

Type of change

Associated Issues

For Linear issues: Closes APKT-1497 For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

linear[bot] commented 1 day ago

APKT-1497 [Bug] SIWE is working weird in v1.5.0

changeset-bot[bot] commented 1 day ago

πŸ¦‹ Changeset detected

Latest commit: 3acbb5d9c2de79ddada25d30ab246020be7bd009

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages | Name | Type | | ------------------------------ | ----- | | @reown/appkit-siwe | Patch | | @apps/demo | Patch | | @apps/gallery | Patch | | @apps/laboratory | Patch | | @reown/appkit-adapter-ethers | Patch | | @reown/appkit-adapter-ethers5 | Patch | | @reown/appkit-adapter-polkadot | Patch | | @reown/appkit-adapter-solana | Patch | | @reown/appkit-adapter-wagmi | Patch | | @reown/appkit | Patch | | @reown/appkit-utils | Patch | | @reown/appkit-cdn | Patch | | @reown/appkit-common | Patch | | @reown/appkit-core | Patch | | @reown/appkit-experimental | Patch | | @reown/appkit-polyfills | Patch | | @reown/appkit-scaffold-ui | Patch | | @reown/appkit-siwx | Patch | | @reown/appkit-ui | Patch | | @reown/appkit-wallet | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
appkit-gallery-new βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 21, 2024 10:57am
appkit-laboratory βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 21, 2024 10:57am
appkit-vue-solana βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 21, 2024 10:57am
appkit-wagmi-cdn-example βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 21, 2024 10:57am
vue-wagmi-example βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 21, 2024 10:57am
github-actions[bot] commented 1 day ago

Coverage Report for Coverage

Status Category Percentage Covered / Total
πŸ”΅ Lines 335.7% 4838 / 23584
πŸ”΅ Statements 335.7% 4838 / 23584
πŸ”΅ Functions 368.88% 388 / 1431
πŸ”΅ Branches 475.80999999999995% 745 / 1724
File CoverageNo changed files found.
Generated in workflow #7500 for commit 3acbb5d by the Vitest Coverage Report Action