reown-com / appkit

The full stack toolkit to build onchain app UX
https://reown.com/appkit
Apache License 2.0
4.94k stars 1.41k forks source link

:fix fix swaps for SA #3303

Open svenvoskamp opened 15 hours ago

svenvoskamp commented 15 hours ago

Description

fix swaps for SA

Type of change

Associated Issues

For Linear issues: Closes APKT-xxx For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state. If new feature is being introduced, include the link to demo recording.

Checklist

changeset-bot[bot] commented 15 hours ago

⚠️ No Changeset found

Latest commit: 4f95183ede5d50b4bee8b79b9e1d93032b7f3f5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 15 hours ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:12am
appkit-laboratory 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:12am
appkit-vue-solana 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:12am
appkit-wagmi-cdn-example 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:12am
vue-wagmi-example 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:12am
github-actions[bot] commented 15 hours ago

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 335.89% 4838 / 23570
🔵 Statements 335.89% 4838 / 23570
🔵 Functions 368.88% 388 / 1431
🔵 Branches 475.65999999999997% 745 / 1725
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 0% 0% 0% 0% 1
packages/core/src/controllers/SwapController.ts 46.35% 60.6% 56.66% 46.35% 40-43, 166-167, 170-171, 180-181, 211-216, 242, 250-252, 261-265, 269-284, 287-300, 311-312, 315-316, 320-321, 329-332, 365, 372, 377-396, 405-407, 420-421, 432-433, 445, 452-453, 457-465, 493-494, 516-517, 531, 540-579, 582-627, 630-681, 685-722, 725-811, 827, 843-844
Generated in workflow #7527 for commit 7ff7f0e by the Vitest Coverage Report Action
arein commented 4 hours ago

FYI tried on the preview link and still getting the same issue - does it maybe not take into account that I have no native token balance on this account but an eligible ERC20?

Screenshot 2024-11-22 at 11 30 03 AM