search

reown-com / web-examples

Wallet and dapp examples implementing WalletConnect v2
https://walletconnect.com
Apache License 2.0
427 stars 347 forks source link

feat(it-just-works): show loading indicator and failure error message in sample wallet #373

Open arein opened 10 months ago

arein commented 10 months ago

Currently after typing in a wc2 URI and clicking connect there is no loading indicator. In web3modal UI tests you can see that often nothing happens without an error message. This blocks parallelizing and improving quality of the web3modal tests.

Expected behavior:

  1. visible loading indicator
  2. timeout with good error message if the session approve model doesn't pop open within X seconds
bkrem commented 9 months ago

@ganchoradkov I think we can close this? There's an ellipsis loading indicator on the Connect button now from what I can see