search

repaint-io / maven-tiles

Injecting maven configurations by composition rather than inheritance
155 stars 32 forks source link

Get rid of legacy #134

Closed cstamas closed 1 year ago

cstamas commented 1 year ago

Drop plexus and any related class (sans plexus-utils, is there to stay), switch from Plx components to JSR230 and drop plexus XML and replace with proper compoments/providers.

Tidy up some things as well.

talios commented 1 year ago

Looks like there's some conflicts there?

cstamas commented 1 year ago

Yes, as it was done against master :smile: you were faster to merge other

cstamas commented 1 year ago

rebased

talios commented 1 year ago

It's almost 1am - I should be sleeping - but I saw the PR just as I was finishing things up :)

cstamas commented 1 year ago

Important note: now that you use sisu-maven-plugin, you are bound to max Java11 (so your project compiler.target or compiler.release) as long this https://github.com/eclipse/sisu.inject/commit/4790d3e28987ee4c2472d576e544c07028a85f42 is not released. In short, Sisu will fail to scan Java 12+ bytecode, but I think you are fine on Java 8 level for now.

talios commented 1 year ago

I assume then, since the majority of the code here is Groovy that it's only generating Java 8 level byte-code (the IT tests run and pass under JDK 18/19).

That is something to keep in mind tho.

talios commented 1 year ago

starts watching sisu.inject in any case

rvowles commented 1 year ago

If this upped the minimum version of Maven, the docs need to be updated as well.

talios commented 1 year ago

Don't think it's upped the minimum - I do see we still have <version>[3.3.9,)</version> in the pom.xml but I don't think that's been valid as a "minimum" for a long time given we depend on maven-core:3.8.4.

Sadly, after releasing this morning I noticed it didn't actually work under 4.0.0-alpha2 - and have since added a pipeline run to run the build and IT tests under the alpha build (which indeed fails - but passes on the rest).