search

repaint-io / maven-tiles

Injecting maven configurations by composition rather than inheritance
155 stars 32 forks source link

Fixes #136

Closed cstamas closed 1 year ago

cstamas commented 1 year ago

1st: sadly https://github.com/repaint-io/maven-tiles/pull/134 contained some mistakes (mixed javax.inject and google.inject annotations), fixed

2nd: ModelBuilder handling improved but still fails with 4-alpha-2 as it contains other incompatible changes (this time with ModelProcessor), still these changes are correct and work with mvn3, but does not fix plugin to work with mvn4alpha2

We will work on restoring compat and hopefully alpha3 will have the changes to make this plugin WITH THESE changes work.

talios commented 1 year ago

Cheers - I just did some tests going back to the original commit for compat and noticed whilst the build and IT tests ran, they failed to correctly inject under 4 - but everything good under 3.

These breakages in alpha-2 are a net-win IMHO - better to find them now than after release! As as long as 3.x remains working it's all good.