search

repaint-io / maven-tiles

Injecting maven configurations by composition rather than inheritance
154 stars 32 forks source link

Unable to attach-tile to an existing project #15

Closed talios closed 9 years ago

talios commented 9 years ago

I had thought we had the ability to attach a tile to an existing project, but it seems that io.repaint.maven.tiles.AttachTileMojo#execute includes an assertion that the projects <packaging> is tile.

We should probably just remove this assertion as the attach-tile goal is triggered by the custom lifecycle already - if you include the plugin and configure an execution it should just work.

rvowles commented 9 years ago

Go look at the groovydoc plugin in my repo to see how this is done. On 19 Oct 2014 18:52, "Mark Derricutt" notifications@github.com wrote:

I had thought we had the ability to attach a tile to an existing project, but it seems that io.repaint.maven.tiles.AttachTileMojo#execute includes an assertion that the projects is tile.

We should probably just remove this assertion as the attach-tile goal is triggered by the custom lifecycle already - if you include the plugin and configure an execution it should just work.

— Reply to this email directly or view it on GitHub https://github.com/repaint-io/maven-tiles/issues/15.

talios commented 9 years ago

Hrm, using the build-helper-maven-plugin feels kinda like a smell and flaw in the tiles-maven-plugin.