search

repaint-io / maven-tiles

Injecting maven configurations by composition rather than inheritance
154 stars 32 forks source link

Plugins not marked as thread safe #96

Closed udalrich closed 5 years ago

udalrich commented 5 years ago

When I try to run a build using mvn -T 1C ..., I get the following warnings:

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in MyTile:
[WARNING] io.repaint.maven:tiles-maven-plugin:2.13
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[INFO] 
[WARNING] *****************************************************************

The build is only using the attach-tile goal.

If the plugin is in fact thread safe, it should be marked as such. If it is unsafe, this should be better documented and (if reasonable) fixed.

rvowles commented 5 years ago

We accept PRs :-)

On Wed, Apr 10, 2019 at 4:44 AM udalrich notifications@github.com wrote:

When I try to run a build using mvn -T 1C ..., I get the following warnings:

[WARNING] [WARNING] Your build is requesting parallel execution, but project [WARNING] contains the following plugin(s) that have goals not marked [WARNING] as @threadSafe to support parallel building. [WARNING] While this /may/ work fine, please look for plugin updates [WARNING] and/or request plugins be made thread-safe. [WARNING] If reporting an issue, report it against the plugin in [WARNING] question, not against maven-core [WARNING] [WARNING] The following plugins are not marked @threadSafe in MyTile: [WARNING] io.repaint.maven:tiles-maven-plugin:2.13 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe. [INFO] [WARNING] *****

The build is only using the attach-tile goal.

If the plugin is in fact thread safe, it should be marked as such. If it is unsafe, this should be better documented and (if reasonable) fixed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/repaint-io/maven-tiles/issues/96, or mute the thread https://github.com/notifications/unsubscribe-auth/AADZ2PuTU6LZqVa8jx5lfee5DBydkKx9ks5vfMN9gaJpZM4ck82U .

--

Richard Vowles, Full stack - from Kubernetes, through Node & Java, Web and Mobile development in Flutter - software developer for hire!

ph: +64275467747, web: www.google.com/+RichardVowles

udalrich commented 5 years ago

Do you know if the code is thread safe? If all I need to do is mark it as such, that's a pretty easy PR to generate. If I have to understand the code and figure out what it does, that will obviously be much more work.

There is a thread-safe checklist at https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3.

bvella commented 5 years ago

It is thread-safe. I looked at the code quite well in January when I submitted a number of PRs and safely say that there are no mutable statics or suspect thread-unsafe constructs