search

repaper / gratis

EPD Source codes and Documentation
238 stars 132 forks source link

Do we need a terminating '\n' in the error strings (/dev/epd/error)? #66

Closed tvoverbeek closed 7 years ago

tvoverbeek commented 7 years ago

In the recent addition of /dev/epd/error in epd_fuse.c the strings representing the error codes (output of 'cat /dev/epd/error') do not have a terminating '\n'. Other strings, e.g. /dev/epd/panel and /dev/epd/version, have a terminating '\n'. Should a '\n' be added to the error text definitions?

hxw commented 7 years ago

actual error text definitions should not have any '\n' but the the access to /dev/epd/error should output a '\n' to conform to other usage.

tvoverbeek commented 7 years ago

The error text definitions are only used for /dev/epd/error output. I'll add the '\n' and submit a new PR.

tvoverbeek commented 7 years ago

Just submitted a PR (#67) with the '\n' addition to the error texts.

tvoverbeek commented 7 years ago

PR is merged now. Closing issue